ladybug-tools / honeybee-energy

🐝 :fire: Honeybee extension for energy simulation
https://www.ladybug.tools/honeybee-energy/docs/
GNU Affero General Public License v3.0
28 stars 18 forks source link

Add new PV and ElecLoadCenter Properties for Extension #1040

Closed ed-p-may closed 2 weeks ago

ed-p-may commented 2 months ago

Hi @chriswmackey , there are two additional Honeybee-Energy objects that I would like to extend with the usual .properties:

This PR adds the needed .properties to both objects, along with the required to_dict, from_dict, and duplicate/__copy__ edits.

Hopefully you agree that this is ok? Note that the naming on the 'PV' one is a little funny: the Honeybee Object itself is already named "PvProperties", even though it is not a normal 'properties' for extension - so I ended up called the extension 'PvPropertiesProperties' which I know is odd, but was trying to follow the pattern from all the others? Not sure what you might think about that though?

Let me know if you think any updates are needed, or you object to this PR for any reason. Thanks! @ed-p-may

ed-p-may commented 1 week ago

Awesome - thanks @chriswmackey !