ladybug-tools / honeybee-energy

🐝 :fire: Honeybee extension for energy simulation
https://www.ladybug.tools/honeybee-energy/docs/
GNU Affero General Public License v3.0
27 stars 17 forks source link

`horizontal orientation angle` = 360 in `ZoneVentilation:WindandStackOpenArea` #959

Closed JunfXiao closed 1 year ago

JunfXiao commented 1 year ago

Hi,

when running my model using HB Peak Loads, I found that sometimes an error showed up:

Program Version,EnergyPlus, Version 22.2.0-aa78da9668, YMD=2023.07.06 16:02,
   ** Severe  ** <root>[ZoneVentilation:WindandStackOpenArea][Floor_1._OG_27_School_d7a9d830..Face1_Glz0_Opening][effective_angle] - "360.000000" - Expected number less than 360.000000
   **  Fatal  ** Errors occurred on processing input file. Preceding condition(s) cause termination.
   ...Summary of Errors that led to program termination:
   ..... Reference severe error count=3
   ..... Last severe error=<root>[ZoneVentilation:WindandStackOpenArea][Floor_1._OG_27_School_d7a9d830..Face1_Glz0_Opening][effective_angle] - "360.000000" - Expected number less than 360.000000
   ************* Warning:  Node connection errors not checked - most system input has not been read (see previous warning).
   ************* Fatal error -- final processing.  Program exited before simulations began.  See previous error messages.
   ************* EnergyPlus Warmup Error Summary. During Warmup: 0 Warning; 0 Severe Errors.
   ************* EnergyPlus Sizing Error Summary. During Sizing: 0 Warning; 0 Severe Errors.
   ************* EnergyPlus Terminated--Fatal Error Detected. 0 Warning; 3 Severe Errors; Elapsed Time=00hr 00min  0.44sec

Runtime error (PythonException):    **  Fatal  ** Errors occurred on processing input file. Preceding condition(s) cause termination.

Traceback:
  line 366, in script

I looked up the idf file, found some WindandStackOpenArea with 360 degree:

...
ZoneVentilation:WindandStackOpenArea,
 Floor_1._OG_27_School_057d195c..Face1_Glz0_aaa_Opening, !- name
 Floor_1._OG_27_School_057d195c, !- zone name
 2.2328,                   !- opening area
 School ON OFF,            !- opening schedule
 autocalculate,            !- opening effectiveness {m2}
 360.0,                      !- horizontal orientation angle
 2.0,                      !- height difference {m}
...

Then I searched the code and found following lines:

https://github.com/ladybug-tools/honeybee-energy/blob/20e8bcb097346fbf0a40ec456ee5dd98089c3982/honeybee_energy/ventcool/opening.py#L274

After adding a line angle = angle % 360 after that and restarting rhino, the problem is solved.

Would you maybe update this line and solve the problem also for others?

mostaphaRoudsari commented 1 year ago

@JunfXiao - Thank you for reporting the issue. Do you want to send a PR to fix this?

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 1.100.7 :tada:

The release is available on:

Your semantic-release bot :package::rocket: