search

ladybug-tools / honeybee-grasshopper-energy

:honeybee: :green_book: :fire: Honeybee Energy plugin for Grasshopper
GNU Affero General Public License v3.0
5 stars 6 forks source link

Hot water bug in HB Thermal Load Balance #353

Closed marctavenier closed 1 year ago

marctavenier commented 1 year ago

Hi,

I believe the following two lines of code https://github.com/ladybug-tools/honeybee-grasshopper-energy/blob/ef5948a23e36901e74e07c330fbe12ff2e0c585c/honeybee_grasshopper_energy/src/HB%20Thermal%20Load%20Balance.py#L136-L137 should read 

        hot_water_ = [hw * 0.25 for hw in hot_water_]
        for hw in hot_water_:

That way here: https://github.com/ladybug-tools/honeybee-grasshopper-energy/blob/ef5948a23e36901e74e07c330fbe12ff2e0c585c/honeybee_grasshopper_energy/src/HB%20Thermal%20Load%20Balance.py#L144-L147 the processed hot water is referenced, as opposed to the original hot water.

Kind regards, Marc

mostaphaRoudsari commented 1 year ago

Thank you, @marctavenier - I assigned this to @chriswmackey to have a look.

chriswmackey commented 1 year ago

Thanks again, @marctavenier !