ladybug-tools / honeybee-legacy

:bee: Honeybee is a free and open source plugin to connect Grasshopper3D to EnergyPlus, Radiance, Daysim and OpenStudio for building energy and daylighting simulation
http://ladybug.tools
Other
124 stars 145 forks source link

Add standard and climate-zone input for mass2Zone and createZone #398

Open mostaphaRoudsari opened 8 years ago

mostaphaRoudsari commented 8 years ago

Updated OpenStudio library has keys for constructions and schedules based on standards and climate-zone. Construction set for couple of building types were empty so I didn't implement it at this point.

This change will automate the process of assigning construction sets and also makes the process of creating template buildings easier.

image

antonszilasi commented 7 years ago

@mostaphaRoudsari I'll get around to doing this just to remind myself I need to use the updated Json in C:\Program Files\OpenStudio 1.12.0\Ruby\openstudio\sketchup_plugin\user_scripts\On Demand Template Generators\resources

antonszilasi commented 7 years ago

@mostaphaRoudsari can you assign this to me?

mostaphaRoudsari commented 7 years ago

@antonszilasi Github doesn't let me to assign it to you but I removed myself. Consider it assigned!

antonszilasi commented 7 years ago

note to self see discussion here: http://www.grasshopper3d.com/group/ladybug/forum/topics/what-is-building-program-and-how-to-customize-it?xg_source=activity

antonszilasi commented 7 years ago

@mostaphaRoudsari @chriswmackey

I was hoping to use a value list for both the climates and the and the standards like the bldgPrograms value list. See below:

climate zone and construction set

Unfortunately, while the building types are consistent in the OpenStudio_Standards.json ("Office","Outpatient","MidriseApartment" etc) the climate zones for the constructions are not:

climatezones

I was thinking is it possible to create a custom valuelist using code so that once the user has selected the standard the available climate types for that standard are displayed? I can't think of any other way to do it.

Let me know your thoughts

mostaphaRoudsari commented 7 years ago

Hi @antonszilasi, Thank you for looking into this. I believe there has been a lot of progress on this during the last year: https://github.com/NREL/openstudio-standards

@asparke2 or @macumber can hopefully help us to find the right way to get the construction set based on climate zone and building type.

mostaphaRoudsari commented 7 years ago

This is how OpenStudio itself does it under the hood: https://github.com/NREL/openstudio-standards/blob/master/openstudio-standards/lib/openstudio-standards/standards/Standards.Model.rb

I'm still not sure how constructions_sets helps the whole process in finding the right constructions.

macumber commented 7 years ago

The constructions end up as a big look up in this file. Then once you find the construction for the climate zone/standard you want, you can look up the construction in this file, and then look up the materials in this file. Finally there is a method set_u_value that tweaks the insulation layer in the construction (if there is one) to meet the total u value.

mostaphaRoudsari commented 7 years ago

Hi @macumber! Thanks. GitHub has removed the last part of your comment but you have already discussed the part that we're facing the issue. I see what has changed now. Constructions are not named based on the standard anymore! Now everything is much more clear. This forces a re-write to our API but I think it totally worth it and is much cleaner than what we do right now. I will be working on this today and can hopefully get it done by the end of the day. We have to also change the library for the schedules and so on.

PS: I don't know how to thank you for your continuous support. You have saved us so many hours by your insights. Thanks again.

chriswmackey commented 7 years ago

@macumber , This is much more organized than the previous version and I'm excited to get this implemented on Honeybee[+] if not sooner. I also echo @mostaphaRoudsari 's sentiment here. Your support has enabled so many things that would not have been possible otherwise. Thank you!!!