search

ladybug-tools / honeybee-legacy

:bee: Honeybee is a free and open source plugin to connect Grasshopper3D to EnergyPlus, Radiance, Daysim and OpenStudio for building energy and daylighting simulation
http://ladybug.tools
Other
125 stars 145 forks source link

HB Generation Battery #630

Open twanito opened 7 years ago

twanito commented 7 years ago

Hi, I've really enjoyed playing around with the renewable energy generation nodes and have been wanting to push it a bit further by carrying out parametric studies to determine best PV module and battery set up for an off-grid system.

I have done a bit of digging into the existing code and it appears everything is already there to create a battery object in Eplus but there is no battery node. I've hacked one which I think works and tried to capture simulation data in the results file with successfully.

My question to @antonszilasi (although I'm sure @mostaphaRoudsari and @chriswmackey could help if you guys have time) is whether this node has been made but just forgotten somewhere? Or is it worth working on this now? I'm happy to give it a go but might need a tiny bit of mentoring to make it work with HoneyBee code. Also note that my "hack" was on the EnergyPlus exporter not the OSM one (quicker and easier to understand) so probably doesn't fit with your future plans for OpenStudio run HoneyBee. If so, what is the best way forward in your opinion?

Cheers!

antonszilasi commented 7 years ago

@twanito Happy to hear that you are interested in renewable energy in Honeybee. Unfortunately I am in a bit of a crunch with work but I do plan to update all my renewable energy code towards the end of this year.

None the less I did write some code to put battery objects in Honeybee here: https://github.com/antonszilasi/Honeybee/tree/storageobjects

on the storageobjects branch of my honeybee, take a look and if you have questions find me on gchat - ajszilasi@gmail.com!

twanito commented 7 years ago

Well thank you for the great groundwork into getting this renewable energy nodes in. I hadn't spotted the one on your Honeybee fork. I'm also happy to see the way I scripted my battery node in was very similar to yours (clearly i was doing something right)!

I understand that you're covered in work at the moment. If I were to fork from your branch and add a few more things (I need a real battery model as opposed to the simplistic one for my project) would you be happy to have a look at the code once I make a pull request? (It'll all be for the energyplus exporter for now as I haven't wrapped my head around openstudio code yet).

antonszilasi commented 6 years ago

@twanito sorry for never getting back to you - for some reason this didn't pop up as a notification on my account.

Please do take my work and run with it! I'll be happy to assist in whatever way I can - the last work I did with the batterys was at: https://github.com/antonszilasi/Honeybee/tree/storageobjects

The Honeybee code is well out of date but if you take the code which I wrote for the batterys and integrate it into the latest Honeybee code that would be the way to do it.

Godspeed!