fix(construction): Ensure output is valid with missing constructions

ladybug-tools / honeybee-openstudio-gem

:honeybee: :gem: Library and measures for translating between Honeybee JSON schema and OpenStudio Model schema (OSM)

Other

6 stars 8 forks source link

fix(construction): Ensure output is valid with missing constructions #209

Closed chriswmackey closed 3 years ago

chriswmackey commented 3 years ago

I realized that the format of window constructions within gbXML doesn't support material layers and so the current setup of the gem meant that almost no gbXMLs were importable back to honeybee. I added in some checks to ensure that, if a construction is not found, we don't assign it to any faces. This keeps the output HBJSON valid and ensures that these objects with missing constructions just get the honeybee default.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 2.18.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: