search

ladybug-tools / honeybee-openstudio-gem

:honeybee: :gem: Library and measures for translating between Honeybee JSON schema and OpenStudio Model schema (OSM)
Other
6 stars 8 forks source link

feat(construction_set): Adds construction set to model #213

Closed tanushree04 closed 3 years ago

tanushree04 commented 3 years ago

Closes #176

tanushree04 commented 3 years ago

This should be ready for review. I think most of the mappings from OS to HB constructions should be okay. For the mapping of interior_construction of aperture_set, I might add a check for the boundary conditions in the aperture surface and add those here.

tanushree04 commented 3 years ago

@chriswmackey I wanted to double check - we want to check for each geometry object here https://github.com/ladybug-tools/honeybee-openstudio-gem/blob/cf7b26391819f2e5e4df168a7a3150d561186040/lib/from_openstudio/geometry/aperture.rb#L72 - if surface.isConstructionDefaulted returns true this indicates construction is not directly referenced by this surface and that construction should be added to the honeybee construction set hash?

chriswmackey commented 3 years ago

Hey @tanushree04 ,

That's mostly correct.

If surface.isConstructionDefaulted returns true, then it is not directly referenced by that surface and that construction should not be added to the hash for that that surface.

The surface.isConstructionDefaulted` has no effect on the translation of Construction Sets. Only the assignment to individual surfaces.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 2.21.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: