search

ladybug-tools / honeybee-openstudio-gem

:honeybee: :gem: Library and measures for translating between Honeybee JSON schema and OpenStudio Model schema (OSM)
Other
6 stars 8 forks source link

fix(geometry): Remove the automatic reorderULC for all vertices #254

Closed chriswmackey closed 2 years ago

chriswmackey commented 2 years ago

After delving a little into the OpenStudio source code, I have realized that the methods we have in ladybug_geometry to obtain the upper-left vertex are a bit better than OpenStudio's. This is particularly so in cases where we have to decide whether the "upper" or the "left" is of a higher importance for a given geometry.

So I now just ensure that the HBJSON that the gem gets will always have vertices fed to it in a manner that is upper-left -counter-clockwise using our methods in ladybug_geometry. And I am removing the methods here that would replace these vertices with a potentially less-accurate version.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 2.28.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: