ladybug-tools / honeybee-openstudio-gem

:honeybee: :gem: Library and measures for translating between Honeybee JSON schema and OpenStudio Model schema (OSM)
Other
6 stars 8 forks source link

Add Option to Turn off Window Triangulation #278

Closed chriswmackey closed 2 years ago

chriswmackey commented 2 years ago

I should really add an option to turn off the triangulation since I'm realizing that other platforms don't have the same restriction that EnergyPlus has with widows that have more than 4 vertices.

For example, people seem to get confused when they see the triangulated windows in their gbXML: https://discourse.ladybug.tools/t/dump-to-gbxml-error/17603/3?u=chris

And we were recently using this gem to help us expose access to HBJSONs in sketchup where we probably don't want the triangulation to take place.

chriswmackey commented 2 years ago

This was addressed via https://github.com/ladybug-tools/honeybee-openstudio-gem/pull/281