search

ladybug-tools / honeybee-radiance-command

🐝 ⚡️ :abc: Honeybee wrapper around Radiance commands which is used by honeybee-radiance
https://www.ladybug.tools/honeybee-radiance-command/docs/
GNU Affero General Public License v3.0
0 stars 6 forks source link

feat(dcglare): added dcglare command and options #198

Closed mikkelkp closed 2 years ago

mikkelkp commented 2 years ago

Allows both two-phase and three-phase matrices. 'dctotal' will be replaced by vmtx*tmtx*dmtx if transmission matrix (tmtx) is given.

mikkelkp commented 2 years ago

Hi @mikkelkp, I haven't used this command enough to be able to see any possible issues. I left two comments about naming and also implementation details.

I strongly suggest to add tests to this PR before merging it in to ensure the command is working as expected.

I changed the naming and added missing docstrings. Also a minor change in to_radiance method. Let me know if the tests file is reasonable.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.14.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: