search

ladybug-tools / honeybee-radiance-command

🐝 ⚡️ :abc: Honeybee wrapper around Radiance commands which is used by honeybee-radiance
https://www.ladybug.tools/honeybee-radiance-command/docs/
GNU Affero General Public License v3.0
0 stars 6 forks source link

fix(getinfo): minor change to 'a' option #201

Closed mikkelkp closed 2 years ago

mikkelkp commented 2 years ago

Just a small fix for the 'a' option if the input does not come from stdin.

mostaphaRoudsari commented 2 years ago

Hi @mikkelkp, Thanks! Can you provide a more human-readable explanation for the reasoning behind this PR? That should help @chriswmackey to be able to review the PR quickly.

mikkelkp commented 2 years ago

Hi @mikkelkp, Thanks! Can you provide a more human-readable explanation for the reasoning behind this PR? That should help @chriswmackey to be able to review the PR quickly.

When appending to the header, the input file is read by "<". For example: getinfo -a "Add to header" < input.hdr > new_image.hdr.

If the input comes from stdin it does not matter, i.e.: pfilt -r 0.6 input.hdr | getinfo -a "Add to header" > new_image.hdr

Currently, only the second example will work right now. The first example should work with this PR. @chriswmackey

chriswmackey commented 2 years ago

Thanks for catching this, @mikkelkp , and I'm sorry that I didn't see it sooner. I'll merge it shortly.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.14.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: