search

ladybug-tools / honeybee-radiance-command

🐝 ⚡️ :abc: Honeybee wrapper around Radiance commands which is used by honeybee-radiance
https://www.ladybug.tools/honeybee-radiance-command/docs/
GNU Affero General Public License v3.0
0 stars 6 forks source link

perf(typing): Improvement to normpath function and corresponding typing tests. #211

Closed ghost closed 2 years ago

ghost commented 2 years ago

@mostaphaRoudsari As you had predicted, this turned out to be not so straightforward. I had to amend a test for rcalc to prevent it from failing due to the change. The test for typing itself turned out to be interesting: https://github.com/ladybug-tools/honeybee-radiance-command/pull/211/files#diff-8970a4edc66908b3aaa2f7a270a0c58d4bfef38c001ce6443cc5f053f5eafb46R19-R24

Across all platforms, the path.exists test fails for a path that is normalized, has quotes and spaces. However, this non-existent path works out fine for Radiance inputs.

I am now testing this repository directly with Radiance commands by running them on Windows and Linux to ensure that they work out properly during runtime as well.

mostaphaRoudsari commented 2 years ago

Hi @built-tools! Am I right that this PR is already included in this one: https://github.com/ladybug-tools/honeybee-radiance-command/pull/212

Should we close this and merge the other one?

ghost commented 2 years ago

@mostaphaRoudsari Yes, the other PR includes everything. I am closing this one.