search

ladybug-tools / honeybee-radiance-command

🐝 ⚡️ :abc: Honeybee wrapper around Radiance commands which is used by honeybee-radiance
https://www.ladybug.tools/honeybee-radiance-command/docs/
GNU Affero General Public License v3.0
1 stars 7 forks source link

feat(rmtxop): Rmtxop command and options #220

Closed ghost closed 2 years ago

ghost commented 2 years ago

@mostaphaRoudsari I have updated the class by removing some of the parameters that should not be exposed (based on a similar discussion for dctimestep).

ghost commented 2 years ago

@mostaphaRoudsari So, I ended up rewriting the class entirely and spent better part of the weekend doing so (because I had gotten 75% of it done during the week and then ran into a bunch of challenges). Anyway, I am fairly satisfied with how it turned out. I also ran several tests with the actual Radiance binary and actual matrix file on both Windows and Linux (had to rig-up a Amazon AWS Ubuntu installation for that and deploy everything there and test the same script over and over :| ) . This tiny bit here ended up causing a fair amount of back and forth between Linux and Windows. Anyway, everything (or at least everything that I tried with several matrices) is working now. You can see the amount of documentation I have added. I do thing that adding a couple of use case examples within the docstrings would be helpful. Please let me know if you have any comments/suggestions.

I will add tests for the options and command before merging.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.20.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: