search

ladybug-tools / honeybee-radiance-command

🐝 ⚡️ :abc: Honeybee wrapper around Radiance commands which is used by honeybee-radiance
https://www.ladybug.tools/honeybee-radiance-command/docs/
GNU Affero General Public License v3.0
1 stars 7 forks source link

fix(command_util): handle large prints to stderr #228

Closed mostaphaRoudsari closed 2 years ago

mostaphaRoudsari commented 2 years ago

This commit reverts the changes that are made in https://github.com/ladybug-tools/honeybee-radiance-command/commit/231de913d0ad2f743bf0f169d3104a98bcee7f50 and https://github.com/ladybug-tools/honeybee-radiance-command/commit/064dbea9079a2ca46810c8decc36ee080a0766d8

Radiance has a specific way of handling warnings and it can print large amount of data to stderr during the command execution which can result in the command hanging for ever. This change reverts back to this commit (https://github.com/ladybug-tools/honeybee-radiance-command/commit/9c1fd04a1e09782e5d502dbe13fe09b85f4a7d50#diff-ba32be4c87f001d23e893532290ec28a66c901ff8667d4d3f60d6630838de1e2) which has been working fine for the last year and adds an exception for the edge case which was failing.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.20.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: