search

ladybug-tools / honeybee-radiance-command

🐝 ⚡️ :abc: Honeybee wrapper around Radiance commands which is used by honeybee-radiance
https://www.ladybug.tools/honeybee-radiance-command/docs/
GNU Affero General Public License v3.0
1 stars 7 forks source link

feat(getinfo): Add class instance specifically to remove header #233

Closed mikkelkp closed 2 years ago

mostaphaRoudsari commented 2 years ago

Hi @mikkelkp! I'm not clear how we may want to use this in honeybee-radiance.

Have you seen the parse_header function?

https://github.com/ladybug-tools/honeybee-radiance/blob/1bf740e32ff6448f0bf6cbc7390e7fcb8151e4c7/honeybee_radiance/reader.py#L161

And also how we deal with a header right now:

https://github.com/ladybug-tools/honeybee-radiance/blob/54027500381018b218bafd9d67b0ad398b135327/honeybee_radiance/cli/util.py#L84

Is your implementation going to make things easier?

mikkelkp commented 2 years ago

Hi @mostaphaRoudsari. I was thinking that in cases where we want to remove the header we might as well pipe the Radiance command to "getinfo -" so we get all in one go.

Example: dctimestep view transmission daylight sky | rmtxop -c 47.4 119.9 11.6 - | getinfo - > grid.ill

mikkelkp commented 2 years ago

Hi @mostaphaRoudsari. I removed the argument from __init___ and instead set the attribute to False. I also added warnings when using 'a' and 'd'.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.21.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: