search

ladybug-tools / honeybee

:honeybee: A python library to create, run and visualize radiance studies. Core library of Honeybee[+].
http://ladybug-tools.github.io/honeybee/docs
GNU General Public License v3.0
94 stars 25 forks source link

Honeybee[+] has incorrect sun positions for analemmas #269

Open RMistrick opened 5 years ago

RMistrick commented 5 years ago

The analemma sun positions appear to be based on a time at the top of the hour, but given that weather data are averages over one-hour intervals, the best time to use is actually the half-hour. This should be done both when the weather file has integer numbers for the hours listed or half-hours. The weather file I am using has half hours (7.5, 8.5, 9.5, etc.), but the solar positions appear to be based on the whole hours given the code on lines 218-220 in sunmatrix.py.

Rick

mostaphaRoudsari commented 5 years ago

@RMistrick,

Thank you for reporting this issue. I won't be able to check this today but you can fix it but removing these lines:

https://github.com/ladybug-tools/honeybee/blob/c8ad67a0b53f6f8dac01d05f7ab535d5f066e6bd/honeybee/radiance/sky/sunmatrix.py#L110-L114

I have a note there that shows it was the result of a change in wea. Let me know if it creates any other issues down the line.

RMistrick commented 5 years ago

Mostapha,

Thanks, I missed those lines, but it makes sense since with my file the hours being used were 0 to 23.

Rick

From: Mostapha Sadeghipour Roudsari notifications@github.com Sent: Monday, March 18, 2019 10:41:03 AM To: ladybug-tools/honeybee Cc: Mistrick, Richard George; Mention Subject: Re: [ladybug-tools/honeybee] Honeybee[+] has incorrect sun positions for analemmas (#269)

@RMistrickhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FRMistrick&data=02%7C01%7Crmistrick%40psu.edu%7C477879bc59ac47b4e5eb08d6abafc068%7C7cf48d453ddb4389a9c1c115526eb52e%7C0%7C0%7C636885168666687429&sdata=YdUmOLMRIuZGjcNnsftwRUqDbrtS7VZeyYe8YAZn04o%3D&reserved=0,

Thank you for reporting this issue. I won't be able to check this today but you can fix it but removing these lines:

https://github.com/ladybug-tools/honeybee/blob/master/honeybee/radiance/sky/sunmatrix.py#L110-L114https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fladybug-tools%2Fhoneybee%2Fblob%2Fmaster%2Fhoneybee%2Fradiance%2Fsky%2Fsunmatrix.py%23L110-L114&data=02%7C01%7Crmistrick%40psu.edu%7C477879bc59ac47b4e5eb08d6abafc068%7C7cf48d453ddb4389a9c1c115526eb52e%7C0%7C0%7C636885168666687429&sdata=2fmu%2Bdax1TUY8No8YkwSwtxJxvp2hNrXuDtkImZIryY%3D&reserved=0

I have a note there that shows it was the result of a change in wea. Let me know if it creates any other issues down the line.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fladybug-tools%2Fhoneybee%2Fissues%2F269%23issuecomment-473938141&data=02%7C01%7Crmistrick%40psu.edu%7C477879bc59ac47b4e5eb08d6abafc068%7C7cf48d453ddb4389a9c1c115526eb52e%7C0%7C0%7C636885168666697443&sdata=B7BD%2B%2Fq7uDxJe4wlgQsljdb37TKUVw4G%2BrxQbchyzfw%3D&reserved=0, or mute the threadhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIJzp2-c5pYvQ5Zn55HKK05bEiK0-VeTks5vX6V_gaJpZM4b57Hs&data=02%7C01%7Crmistrick%40psu.edu%7C477879bc59ac47b4e5eb08d6abafc068%7C7cf48d453ddb4389a9c1c115526eb52e%7C0%7C0%7C636885168666697443&sdata=dO1IvplBolgKLluu1YOyJq7ZKw8KJXIoInhYp%2Fp8mxw%3D&reserved=0.