search

ladybug-tools / honeybee

:honeybee: A python library to create, run and visualize radiance studies. Core library of Honeybee[+].
http://ladybug-tools.github.io/honeybee/docs
GNU General Public License v3.0
93 stars 25 forks source link

Missing arg "view_direction" in generate_interior_view() #336

Open maurodeluca opened 4 years ago

maurodeluca commented 4 years ago

https://github.com/ladybug-tools/honeybee/blob/9d1e52fb01794c6c6f5befeb827309040e8a34fe/honeybee/room.py#L217

mostaphaRoudsari commented 4 years ago

The direction is defined by using angle input:

https://github.com/ladybug-tools/honeybee/blob/9d1e52fb01794c6c6f5befeb827309040e8a34fe/honeybee/room.py#L180-L183

maurodeluca commented 4 years ago

Ok, but view_direction is not set in the View() function. It's third argument is view_direction not view_up_vector. If you call generate_interior_value() with no args there is an ValueError, try it for yourself.

mostaphaRoudsari commented 4 years ago

@maurodeluca, can you share a sample code to regenerate the error?

maurodeluca commented 4 years ago

>>> from honeybee.room import Room Failed to load paths from C:\Python27\lib\site-packages\honeybee\config.json. Path to radiance is set to: c:/radiance >>> r = Room()
>>> r.generate_interior_view() Traceback (most recent call last): File "<stdin>", line 1, in <module> File "C:\Python27\lib\site-packages\honeybee\room.py", line 218, in generate_interior_view x_resolution, y_resolution, view_shift, view_lift) File "C:\Python27\lib\site-packages\honeybee\radiance\view.py", line 123, in __init__ self.view_up_vector = view_up_vector File "C:\Python27\lib\site-packages\honeybee\radiance\datatype.py", line 462, in __set__ raise ValueError(msg) ValueError: The specified input for vu (view up vector) is 0. The value should be a list or a tuple.