ladybug-tools / ladybug-blender

:beetle: :orange_book: Ladybug plugin for Blender
GNU General Public License v3.0
46 stars 9 forks source link

LB tris/quads/ngons? #15

Open ppaawweeuu opened 3 years ago

ppaawweeuu commented 3 years ago

Is there limitation to tris and quads? No ngons?

vertices

ppaawweeuu commented 3 years ago

I see that ngons can cast shadows but can not be receiver/sensor.

tris

Moult commented 3 years ago

Hehehehe I guess that helps answer my question here: https://github.com/ladybug-tools/ladybug-blender/blob/master/ladybug_tools/togeometry.py#L197

If @mostaphaRoudsari / @chriswmackey can clarify when ngons are / aren't allowed, I can update the translator to enforce tessellation at certain points.

mostaphaRoudsari commented 3 years ago

We only support faces with 3 or 4 vertices in ladybug_geometry. This should not be a major limitation since every ngon mesh face can be broken down into faces with 3 or 4 vertices.

Also, the reason for meshing is to generate the location and direction of the sensors. We use the center of each mesh face (and not the vertices) for the calculation. A good approach is to try to keep the size of the cells close to each other.

Moult commented 3 years ago

Re-opening, since this is still a bug that can be fixed. Users should feel confident that they can just drop in any object even if it includes ngons, and ideally the node should detect it and tessellate when necessary.