search

ladybug-tools / ladybug-dynamo

:beetle: :blue_book: Ladybug library and plugin for DynamoBIM
http://www.ladybug.tools/ladybug.html
GNU General Public License v3.0
31 stars 13 forks source link

RoomToZones: The results don't seem to reflect the fact there is a roof above #20

Closed mostaphaRoudsari closed 8 years ago

mostaphaRoudsari commented 8 years ago

Reported here.

@Lexiko I think this is a result of having Volume computations set to Area only in Revit. If that's the case then I need to add an extra check and raise an error for the user to change it. We can change it automatically but that might not be what revit and revit users want!

mostaphaRoudsari commented 8 years ago

I still don't know how to fix this but it happens because elementsData.GetBoundaryFaceInfo(face) returns an empty list for roof face in this model.

image

mostaphaRoudsari commented 8 years ago

@Lexiko I checked the model and you're using offset to create the upper level and also create the room. Because of that Revit doesn't assign a corresponding boundary information for the top face of the room and that's why it returns an empty list. I recreated without offset and it works as expected. I can add an exception to raise if there is a case similar to this case. What are your thoughts on this?

mostaphaRoudsari commented 8 years ago

I made the code more forgiving for this case. Seems to be a common practice to create rooms similar to this model. @Lexiko the latest version should have all the issues that you have found fixed. Version 0.0.6.

Lexiko commented 8 years ago

hI @mostaphaRoudsari , yes i think that's a good idea. I thought about it and there are cases where, for example, there may be a split level or double height space where the room would have to be adjusted after placement. fixing this was definitely worthwhile, making the workflow more robust.