search

ladybug-tools / ladybug-geometry

🐞 📦 A library with geometry objects used throughout the Ladybug Tools core libraries
https://www.ladybug.tools/ladybug-geometry/docs/
GNU Affero General Public License v3.0
26 stars 23 forks source link

fix(face): Fix bug in Face3D automatic normal calculation #138

Closed chriswmackey closed 4 years ago

chriswmackey commented 4 years ago

Man, this one was really deep in there but this should hopefully be the last time that I need to fix this function. There were some rare cases where ladybug_geometry would calculate the face normal in the opposite direction from what it actually was. This was the result of me computing the cross product of non-unit vectors. With the extra unit-ization added by this commit, the normal should be computed correctly for any planar Face3D.

ladybugbot commented 4 years ago

:tada: This PR is included in version 1.20.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: