fix(face3d): Improve the normal calculation for slightly nonplanar faces

ladybug-tools / ladybug-geometry

🐞 📦 A library with geometry objects used throughout the Ladybug Tools core libraries

https://www.ladybug.tools/ladybug-geometry/docs/

GNU Affero General Public License v3.0

23 stars 22 forks source link

fix(face3d): Improve the normal calculation for slightly nonplanar faces #247

Closed chriswmackey closed 3 years ago

chriswmackey commented 3 years ago

It seems that Rhino still considers a brep face to be planar if it's planar to within the model relative tolerance even if it's not planar to within absolute tolerance.

To help with this, I am tweaking the calculation of the normal for Face3Ds that have such odd planarity characteristics. Like Rhino, the resulting normal should be correct to within relative tolerance but not absolute tolerance. So it's not perfect but it seems like it's a fair way to treat such less-than-perfect geometry.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.23.3 :tada:

The release is available on:

GitHub release
v1.23.3

Your semantic-release bot :package::rocket: