search

ladybug-tools / ladybug-geometry

🐞 📦 A library with geometry objects used throughout the Ladybug Tools core libraries
https://www.ladybug.tools/ladybug-geometry/docs/
GNU Affero General Public License v3.0
23 stars 22 forks source link

Ladybug Geometry 'dictutil' converter function #311

Closed ed-p-may closed 3 years ago

ed-p-may commented 3 years ago

Adds a new converter function to ladybug_geometry. Similar to the existing 'dictutil' for Honeybee. Takes in a dict and converts to back Ladybug Geometry Object (reverses the .to_dict method). Includes unit tests.

CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: PH-Tools
:x: edpmay
You have signed the CLA already but the status is still pending? Let us recheck it.

ed-p-may commented 3 years ago

Great - thanks @chriswmackey ! I appreciate the detailed notes - apologies for the mistakes there. I have updated everything as per your comments and verified that all tests are still passing. I've revised this commit with the new code. Let me know if there is anything else though or if I did anything incorrectly with the update? Happy to revise.

thanks! @PH-Tools

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.23.13 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

ed-p-may commented 3 years ago

Great! thanks for helping me get this PR sorted. Glad it worked. @PH-Tools

chriswmackey commented 3 years ago

NP. Welcome to the contributor's list!