ladybug-tools / ladybug-geometry

🐞 📦 A library with geometry objects used throughout the Ladybug Tools core libraries
https://www.ladybug.tools/ladybug-geometry/docs/
GNU Affero General Public License v3.0
23 stars 22 forks source link

fix(line): Add a test for signed zeros in line 2D intersection #326

Closed chriswmackey closed 2 years ago

chriswmackey commented 2 years ago

It seems that colinear segments that do not overlap will return an intersection if they are colinear to within Python floating point tolerance.

Adding a check for a negative zero seems to catch this case while leaving all others undisturbed.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.23.23 :tada:

The release is available on:

Your semantic-release bot :package::rocket: