search

ladybug-tools / ladybug-geometry

🐞 📦 A library with geometry objects used throughout the Ladybug Tools core libraries
https://www.ladybug.tools/ladybug-geometry/docs/
GNU Affero General Public License v3.0
25 stars 23 forks source link

fix(face): Ensure that self-intersection check happens for each loop #379

Closed chriswmackey closed 1 year ago

chriswmackey commented 1 year ago

This should finally fix the fact that honeybee has not been able to identify self-intersecting Face3Ds.

We're also changing the Polygon2D.is_self_intersecting method to be true to the real shape regardless of whether it was created with the from_shape_with_hole method. This seems like a more honest way of dealing with Polygons were the boundary has been merged into the holes.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.28.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: