search

ladybug-tools / ladybug-geometry

🐞 📦 A library with geometry objects used throughout the Ladybug Tools core libraries
https://www.ladybug.tools/ladybug-geometry/docs/
GNU Affero General Public License v3.0
26 stars 23 forks source link

Add Cone3D #82

Closed santiagogaray closed 4 years ago

santiagogaray commented 4 years ago

Happy New Year @chriswmackey, Sorry it took that long to get back to this, very excited to be back!

As you suggested I did clean up the fork and started a new PR with an initial Cone3D class for your review. When you get a chance please let me know your thoughts about constructor parameters as well as the properties included. Also feel free to add any functionality that may be useful to have in this geometry object.

chriswmackey commented 4 years ago

Thanks @santiagogaray . I will review this as soon as I get the chance (hopefully today).

santiagogaray commented 4 years ago

Thanks @chriswmackey for taking the time to review everything. Feel free to take a look at the changes addressing your comments. I also added some cone tests for your review.

ladybugbot commented 4 years ago

:tada: This PR is included in version 1.10.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: