search

ladybug-tools / ladybug-geometry

🐞 📦 A library with geometry objects used throughout the Ladybug Tools core libraries
https://www.ladybug.tools/ladybug-geometry/docs/
GNU Affero General Public License v3.0
26 stars 23 forks source link

fix(face3d): Fix sub_faces_by_dimension_rectangle method #83

Closed chriswmackey closed 4 years ago

chriswmackey commented 4 years ago

It seems the previous commit wasn't built to handle any rectangle except one at the origin in the XY plane. This commit fixes it and adds a more public method that can be used to generate sub-faces for a given parent Face3D.

It seems the docstrings in the previous merge were also not correct and these are fixed now.

ladybugbot commented 4 years ago

:tada: This PR is included in version 1.10.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: