search

ladybug-tools / ladybug-geometry

🐞 📦 A library with geometry objects used throughout the Ladybug Tools core libraries
https://www.ladybug.tools/ladybug-geometry/docs/
GNU Affero General Public License v3.0
26 stars 23 forks source link

feat(polyskel.py): add straight skeleton function to 2d polygons #87

Closed saeranv closed 4 years ago

saeranv commented 4 years ago

Adding polyskel.py and polyskel_test.py (first draft). This should work for convex geoms, but not concave get. Apologies for multiple commits with varying degrees of semantic versioning, had some issues with git cz at first.

claassistantio commented 4 years ago

CLA assistant check
All committers have signed the CLA.

mostaphaRoudsari commented 4 years ago

@saeranv, in case you haven't seen them already your tests are failing on Python 2.

Also don't worry about the extra commits. We will clean it before merging them in.

chriswmackey commented 4 years ago

Thanks @saeranv . I'll review shortly.

saeranv commented 4 years ago

Heads up @chriswmackey, I'll be sending a new PR shortly addressing @mostaphaRoudsari comments, you might want to delay you're review until then.

chriswmackey commented 4 years ago

Ok. @saeranv . It's also fine to reopen and continue working within the same PR (as @mostaphaRoudsari said, we'll just squash and merge).

chriswmackey commented 4 years ago

Ah, I see you already opened the new one. Never mind.