search

ladybug-tools / ladybug-grasshopper

🐞 :green_book: Ladybug plugin for Grasshopper
GNU Affero General Public License v3.0
39 stars 16 forks source link

Consider adding a workaround for subprocess.PIPE #265

Open chriswmackey opened 3 years ago

chriswmackey commented 3 years ago

It seems that using subprocess.PIPE can be dangerous on Windows machines: https://stackoverflow.com/questions/5069224/handling-subprocess-crash-in-windows

.... and this is causing a crash of Rhino on some machines: https://discourse.ladybug.tools/t/ladybug-cumulative-sky-matrix-crashes-gh-and-rhino-without-crash-report/15648

We should try to find a workaround for this in the "LB Cumulative Sky Matrix" first. If the solution works well, we can roll it out to the other places where we are currently using subprocess.PIPE on Windows.

paratrooper101 commented 1 year ago

Dear Chris, as I am having the same issues in Ladybug as discussed under https://discourse.ladybug.tools/t/ladybug-cumulative-sky-matrix-crashes-gh-and-rhino-without-crash-report/15648 , is there a solution today how to run gh components such as LB cumulative sky matrix (and LB benefir sky matrix) ?

paratrooper101 commented 1 year ago

I have double checked the https://github.com/ladybug-tools/lbt-grasshopper/wiki/1.4-Compatibility-Matrix to make sure to have each current version. The issues are just the same as discussed. The gh sample https://discourse.ladybug.tools/uploads/short-url/dpZ5TuWoGCwj5vhWrhPRhvryGeF.gh was readable in gh Thank you in advance for further advice, best regards from Stuttgart, Clemens