search

ladybug-tools / ladybug-legacy

:beetle: Ladybug is an environmental plugin for Grasshopper.
http://ladybug.tools
Other
194 stars 82 forks source link

LB Radiation analysis component [disFromBase] error #350

Closed Omidmr closed 7 years ago

Omidmr commented 7 years ago

Hi @chriswmackey , LB Radiation analysis component [distance From Base] input, doesn't accept geo. image 4

"" Current document units is in Meters Conversion to Meters will be applied = 1.000 Runtime error (MissingMemberException): 'Guid' object has no attribute 'float' Traceback: line 269, in main, "" line 493, in script "" reference: http://www.grasshopper3d.com/group/ladybug/forum/topics/strange-error-with-ladybug-radiation-analysis-following-update?xg_source=activity

Kind regards, Omid.

devang-chauhan commented 7 years ago

@Omidmr Can you please elaborate why you are providing a geo to this input? Can you not provide a float?

Omidmr commented 7 years ago

Hi @devngc ! thanks. It's not my personal issue. I agree with you with float & number. Btw, I think it can be useful sometimes. or for the specific purpose.

best, Omid.

mostaphaRoudsari commented 7 years ago

Hi @Omidmr! I also commented in grasshopper group but probably here is a better place to discuss this. Are you proposing an option to use a different geometry to create the test points? I'm not sure if this is a bug report or a feature request.

mostaphaRoudsari commented 7 years ago

I think I know what is the issue now. The input type hint is missing.

Omidmr commented 7 years ago

Hi @mostaphaRoudsari, Thanks for the reply.

I think it's interesting as the second option for creating test points with surface instead number ( by that can will be cull unwanted areas of surfaces for analysis). I'm trying for preparing an option for that if I can. best.

chriswmackey commented 7 years ago

Hello all,

For the sake of concluding the issue about the type hints, I have added all of these into the Ladybug analyses: https://github.com/mostaphaRoudsari/ladybug/commit/9904949034eecf02601d518e7651a1267c55b2d2

I'll leave this issue open but I have to say that I do not understand the feature request proposal. Aren't we already putting in a _geometry to generate the test points on all of the 3 Ladybug analyses? How would we put in another geometry to set the distance from the base surface for this geometry?

Omidmr commented 7 years ago

Thanks, @chriswmackey, Currently I think it's no need another option for creating test points. Until I write that. I close this. Thanks again.