search

ladybug-tools / ladybug-legacy

:beetle: Ladybug is an environmental plugin for Grasshopper.
http://ladybug.tools
Other
192 stars 82 forks source link

Added TIFF checking #404

Closed MingboPeng closed 6 years ago

chriswmackey commented 6 years ago

@MingboPeng , I don't see any changes to a .py file but I trust that this is good and I'll merge it. Are you just changing type hints on the userobject?

MingboPeng commented 6 years ago

Hi @chriswmackey , I did change in C#, this is just the gha file:>

chriswmackey commented 6 years ago

Ahh, right. I forgot it was written in C#. I just realized that we should also have you commit a C# file to the src folder just as @mostaphaRoudsari did with the Fly component: https://github.com/mostaphaRoudsari/ladybug/blob/master/src/Ladybug_Fly.cs

Alternatively, we could just include a link to your repository in the component description. It would just be good to let people know where to find the source code somewhere on the component. Let me know if you have a preference of one method over another or any other ideas/suggestions.

On a related note, your newest Colibri component has blown Fly out of the water! It's really become the best iterator component in the GH community. Given that I see people moving to use Colibri over Fly and I am personally planning on using Colibri in all of my future tutorial videos, I think I might move Fly to below the Extra Tab for this release. This will also make things more balanced in the Extra tab with your new awesome component in the same location.

In summary, great job! Your components are re-shaping AEC workflows!

MingboPeng commented 6 years ago

@chriswmackey I am sorry for poor writing of the component descriptions. I will add the source link. Thanks, and we all are trying to it better.

chriswmackey commented 6 years ago

@MingboPeng , It's definitely not poor writing and the way that we reference the source code for your component is new and unique given that you have re-written the entire component interface. So no worries and just send a pull request whenever you're ready today.