search

ladybug-tools / ladybug-legacy

:beetle: Ladybug is an environmental plugin for Grasshopper.
http://ladybug.tools
Other
195 stars 82 forks source link

Ladybug_SunPath angles #422

Closed Vyrwn closed 6 years ago

Vyrwn commented 7 years ago

@chriswmackey, in my opinion we should include the stereographic projection on the reverse angle inside ladybug ladybug. image

otherwise the angles do not appear correct on the stereographic projection. So in the end it will look like this.

image

I also added the "°" in the code but this is personal view.

Let me know if you agree on the above so I can push it.

chriswmackey commented 7 years ago

@Vyrwn , Good catch. The angles should match with the other projection. Feel free to send a pull request with this and I will merge it in. Or did you already fix this here: https://github.com/mostaphaRoudsari/ladybug/pull/423/files#diff-b9af826a74ec3aa0ea71038078755d9cL3094 ?

Vyrwn commented 7 years ago

@chriswmackey , yes this was already included in the pull request. I did not add the ° symbol though.

chriswmackey commented 6 years ago

I forgot to close this one out. Thanks for fixing this @Vyrwn !