ladybug-tools / ladybug-legacy

:beetle: Ladybug is an environmental plugin for Grasshopper.
http://ladybug.tools
Other
194 stars 82 forks source link

Location output: importEPW vs importLoc #446

Closed ayezioro closed 6 years ago

ayezioro commented 6 years ago

Hi, I've found today a difference in the way both components give the location output.

capture When you use the output of the importLoc to the sunPath you get the following error:

  1. Solution exception:need more than 5 values to unpack

I noticed that this component is using the LadybugPlus library. As a matter of fact this component is the same of the LadybugPlus.

FYI.

Thanks, -A.

chriswmackey commented 6 years ago

@ayezioro , I think that you have just gotten the ladybugplus component confused with the ladybug legacy one. Form what I can tell on the github here, the legacy component seems to be the same as it has always been:

https://github.com/mostaphaRoudsari/ladybug/blob/master/src/Ladybug_Import%20Location.py

I'll do a sanity check when I get home.

ayezioro commented 6 years ago

Thanks @chriswmackey, You are right. I can't explain how it happens since i'm sure i was in the Ladybug tab picking the component. Checking now i see that the component is fine. Sorry for the bother. -A.

chriswmackey commented 6 years ago

No worries. Glad it was that simple to fix :)