search

ladybug-tools / ladybug-legacy

:beetle: Ladybug is an environmental plugin for Grasshopper.
http://ladybug.tools
Other
192 stars 82 forks source link

sunrise sunset bugfix #448

Closed Sonderwoods closed 5 years ago

Sonderwoods commented 5 years ago

disabled the mistakenly baked points in sunpath

chriswmackey commented 5 years ago

@antonelloDN , Do you have any comments on this one?

@sonderwoods had explained the issue to me and it seems like a good patch though I am sure there are some more elegant solutions like using Rhinocommon instead of rhinoscript. I plan to merge it in of I don't hear from you but just let me know if you plan to implement a better solution.

AntonelloDN commented 5 years ago

Hi @chriswmackey

I do not undestand well the issue because I do know how to replicate it. I image something related to bake functionality of Grasshopper. Anyway, the solution of @Sonderwoods avoid creation of points and it can work. So you can merge it.

Agree with you, the better and elegant solution could be Rhinocommon. Let me know if I have to translate it from rhinoscriptsyntax to Rhinocommon.

Antonello

chriswmackey commented 5 years ago

I thin that the issue is just simply that the component is putting poiunt in the scene without the user telling the component to bake the points. @sonderwoods 's forum issue where he describes it is here:

https://discourse.ladybug.tools/t/sunrise-sunset-component-bakes-points/3691

I will merge the PR in. There's no urgent need to move to Rhinocommon if you are busy, @antonello.