search

ladybug-tools / ladybug-legacy

:beetle: Ladybug is an environmental plugin for Grasshopper.
http://ladybug.tools
Other
192 stars 82 forks source link

Avoiding Div/0 in MeshSelector #464

Closed hwoehrle closed 4 years ago

hwoehrle commented 4 years ago

Avoiding Div/0 when none of the TestPoints meet the levelOfPerformance. This is necessary because otherwise the script stops and doesn't evaluate further resultets

hwoehrle commented 4 years ago

Sorry, i'm using github for the first time and of course started editing the wrong lines. Just ignore the older commits

devang-chauhan commented 4 years ago

Thanks for addressing this

chriswmackey commented 4 years ago

Thanks for fixing this, @hwoehrle . And no worries about sending multiple commits (we can squash them all into one when we merge them).

Your changes look good but one small edit that would be good to have before we merge it is if you can change the date on the component to today's date. If you send us another commit with the date changed, I'll merge this in.

hwoehrle commented 4 years ago

this time with changed date of the component

chriswmackey commented 4 years ago

@hwoehrle ,

It looks like you overwrote the code change that you were adding when you pushed this commit. Make sure that the component you are exporting has both the change for div/0 as well as the date change and then it all should be good.

hwoehrle commented 4 years ago

Ok, i'm stumbling to the finish line ;-)

chriswmackey commented 4 years ago

Looks excellent @hwoehrle ! Merged!

chriswmackey commented 4 years ago

Welcome to the contributor's page @hwoehrle !