search

ladybug-tools / ladybug-legacy

:beetle: Ladybug is an environmental plugin for Grasshopper.
http://ladybug.tools
Other
192 stars 82 forks source link

Bug fix in CEC PV Module #483

Closed devang-chauhan closed 4 years ago

devang-chauhan commented 4 years ago

This PR is done in response to this discussion.

chriswmackey commented 4 years ago

@devngc ,

@mostaphaRoudsari moved all of the components into a different tab yesterday and you didn't sync your fork before you made your changes. So we won't be able to merge this in until you've done so.

Otherwise, your changes look good.

devang-chauhan commented 4 years ago

@chriswmackey, Thank you for the information. I did sync before sending that PR. For some reason, syncing never works at my end. All this whenever I want to send a PR, I will delete my fork, re-fork, clone on my machine, replace files and then will send a PR. I have not been able to find a solution to this process.

chriswmackey commented 4 years ago

Deleting and re-forking is the "manual" way to do it and it should always work. The automatic way is honestly not that much faster but it pays off if you are regularly sending a lot of PRs. I find it easier to use GitKraken to do the automatic re-syncing of my fork rather than Github for Windows or using Command Line. GitKraken has a feature to "Reset branch to this commit" that I use for re-syncing.