search

ladybug-tools / ladybug-legacy

:beetle: Ladybug is an environmental plugin for Grasshopper.
http://ladybug.tools
Other
194 stars 82 forks source link

Wish - Window/door Recess component #67

Closed arkdanielnielsen closed 8 years ago

arkdanielnielsen commented 10 years ago

A component that makes window/door recess. New regulations in Denmark results in walls up to 500mm thick, and with passive houses walls can even be 600mm! This have some impact on daylight studies (and a little on the energy studies) because of shade from the recess depth.

With similar input as "Honeybee EP context Surfaces".

honeybee_wish_window-door-recess-component-01

chriswmackey commented 10 years ago

Hi Daniel, Generating window recess outlines should be a really easy thing to do. It's literally a matter of duplicating the border and then extruding it. I'll see if I can whip up something quick in the near future.

arkdanielnielsen commented 10 years ago

@chriswmackey I think I will try to make this component my self. For a long while I have wanted to get started with Python, and this is maybe a good and fairly easy component to make. Or else I hope you guys can help me :-)

Maybe I could use some part of the Shading Designer and the Context component?

mostaphaRoudsari commented 10 years ago

@arkdanielnielsen sounds great! Go for it and let us know if you have any question. :+1:

You need to:

  1. Find the edges of brep (https://github.com/mostaphaRoudsari/Honeybee/blob/ba577f110430a7bd328ecf998a1d0c1010448d52/src/Honeybee_Glazing%20based%20on%20ratio.py#L67)
  2. Find normal point the surface (which you can do in center of the face) (https://github.com/mostaphaRoudsari/Honeybee/blob/master/src/Honeybee_Honeybee.py#L3438-L3450) and finally extrude the lines, or move the lines and loft them. I leave this one to you. Just make sure it also works for your curvy building! ;)
chriswmackey commented 10 years ago

This is great!!

I would suggest looking through Rhino Common for that last extrusion step: http://4.rhino3d.com/5/rhinocommon/index.aspx The method for extrusion is under the "Geometry" class and the "Surface" class within this.

I don't know what experience you have with code but feel free to post any questions here and I can give you a quick crash course in making GH python components if you're not sure where to start.

arkdanielnielsen commented 10 years ago

Thanks for the suggestions. It will properly take little bit of time, so be patient with me ;) I think I will start by looking in the Python Primer before I get started on the real stuff.

mostaphaRoudsari commented 9 years ago

@arkdanielnielsen how is your progress with this one? Let us know if you need any help.

arkdanielnielsen commented 9 years ago

@mostaphaRoudsari I have been busy the last couple of weeks unfortunately, but hopefully in the end of this week I will have time to get started. Probably I will need some assistance - I will let you know :)

mostaphaRoudsari commented 8 years ago

@sariths developed a component for this which is almost ready to go. Someone needs to check the component and make sure it qualifies Ladybug/Honeybee component standards. http://www.grasshopper3d.com/group/ladybug/forum/topics/discussion-accuracy-of-daylight-simulations-with-no-wall?commentId=2985220%3AComment%3A1388667&groupId=2985220%3AGroup%3A658987 and https://www.youtube.com/watch?v=xYvc25KT1Nw&feature=youtu.be

sariths commented 8 years ago

Hi @mostaphaRoudsari , are the coding standards documented somewhere ? I can keep that in mind next time when I am scripting something.

chriswmackey commented 8 years ago

@sariths , It is good timing that you ask. We have just posted a set of graphic standards and guidelines for the components the other day: https://github.com/mostaphaRoudsari/ladybug/blob/master/resources/Ladybug%20Grahpic%20Standards.md If you could do some self-checking to see if your component meets these criteria, we can check everything quickly and integrate the component faster.

-Chris

sariths commented 8 years ago

@chriswmackey Thanks! (And thanks again for the informative, and very entertaining, videos on E+ Energy Simulations on youtube). The guidelines answered almost all my questions. Here are a few things that I am not sure about:

antonszilasi commented 8 years ago

@sariths

  1. Better to use photoshop to design the icons. See the existing icons here: https://www.dropbox.com/s/vb5kcvd2tgwb7wc/logos_Rev01.ai?dl=0
  2. You need to put the date of the component and the latest HB LB version like so in the top of the code

ghenv.Component.Name = "Honeybee_ Run Energy Simulation" ghenv.Component.NickName = 'runEnergySimulation' ghenv.Component.Message = 'VER 0.0.57\nOCT_05_2015' ghenv.Component.Category = "Honeybee" ghenv.Component.SubCategory = "09 | Energy | Energy"

compatibleHBVersion = VER 0.0.56\nFEB_28_2015

compatibleLBVersion = VER 0.0.59\nFEB_01_2015

ghenv.Component.AdditionalHelpFromDocStrings = "1"

  1. If the component really doesn't work when the assertion fails better to go with red, you will also need to stop the component running completely. We do this with the checktheinputs statement which return nothing if the assertion fails.
  2. The E+ Run component is quite well scripted take a look as this as a standard to measure your component against.
sariths commented 8 years ago

@antonszilasi Thanks!

antonszilasi commented 8 years ago

@sariths you're welcome and please excuse my many spelling and grammar mistakes I wrote that reply on my phone!