search

ladybug-tools / ladybug

🐞 Core ladybug library for weather data analysis and visualization
https://www.ladybug.tools/ladybug/docs/
GNU Affero General Public License v3.0
196 stars 54 forks source link

fix(epw): Fixed a bug in the EPW.to_wea header #539

Closed ghost closed 2 years ago

ghost commented 2 years ago

The term for "weather_data_file_units" is being written out as "weather_data_file_unit". This causes dctimestep to raise an error.

Before the fix: 2021-12-21 15_49_15-D__Seattle wea - Notepad++

After the fix: 2021-12-21 15_49_36-D__Seattle wea - Notepad++

ghost commented 2 years ago

Additional notes:

  1. This is indeed a bug i.e. not trying to change something to make it work with Radiance.
  2. The header has been correctly set for the Wea class.
mostaphaRoudsari commented 2 years ago

Hi @built-tools! Thank you for the fix. I'm merging it in.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 0.39.33 :tada:

The release is available on:

Your semantic-release bot :package::rocket: