fix(sunpath): Ensure daylight savings is respected for sunrise/sunset

ladybug-tools / ladybug

🐞 Core ladybug library for weather data analysis and visualization

https://www.ladybug.tools/ladybug/docs/

GNU Affero General Public License v3.0

196 stars 54 forks source link

Closed chriswmackey closed 1 year ago

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 0.41.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

charliebrookerBH commented 1 week ago

Hi @chriswmackey, hope you're well.

I just opened the old script I made around this and it wasn't behaving as expected.

I think that if is_daylight_savings, then it should be +1 to the times, rather than -1. Hopefully I've got that right, DST is a pain!!

Cheers, Charlie