search

ladybug-tools / ladybug

🐞 Core ladybug library for weather data analysis and visualization
https://www.ladybug.tools/ladybug/docs/
GNU Affero General Public License v3.0
191 stars 54 forks source link

EPW.from_missing_values() returns non-real dates, renders EPW unusable #592

Closed morgan-sc2 closed 1 year ago

morgan-sc2 commented 1 year ago

Hello, this is my first issue report, but it appears nobody has previously reported a bug that I seem to be encountering in the EPW.from_missing_values() function.

Essentially, the function creates not-real dates for the last hour of a given month, assigning the next month to that hour and resulting in dates that EnergyPlus does not recognize and errors out. To give an example, the hour which should be "1,31,24" (the last hour of January) is actually encoded as "2,31,24" (not a real date) and so on for every month.

This seems to be a root issue in the function itself. Below is a screenshot of the relevant portion of the EPW (in Excel) generated from from_missing_values(), with no other changes made.

At the moment, the only workaround is to convert the EPW to a string and make the changes manually, but it's not very graceful.

Thanks!

image

chriswmackey commented 1 year ago

I'm pretty sure that I fixed this a few months ago. What version of the ladybug library are you using? Can you try updating and see if you still get this case?

chriswmackey commented 1 year ago

I can't recreate this case with the latest ladybug library so I'm going to assume that this is just an outdated issue and that updating the library will fix it. Feel free to reopen if I'm wrong.