search

ladybug-tools / ladybug

🐞 Core ladybug library for weather data analysis and visualization
https://www.ladybug.tools/ladybug/docs/
GNU Affero General Public License v3.0
191 stars 54 forks source link

Click v7 Dependency Incompatibility #597

Closed ed-p-may closed 5 months ago

ed-p-may commented 1 year ago

Hi,

I am running into trouble with the 'Click v7' dependency requirement. Currently this dependency appears to be pinned as v7.1.2, however Click appears to now be up to v8.1.3

The reason that I notice is that when ladybug-core is installed alongside some other packages, a version incompatibility warning will get thrown by pip. Notably: the current version (23.3.0) of the autoformatter "Black" requires click >8. This incompatibility means that any package using ladybug-core breaks Black, and autoformatting no longer works.

The workaround seems to be to install the older version of Black (v23.1.0) for now.

Is it possible to update this click dependency to the current version?

thank you! Ed, @PH-Tools

chriswmackey commented 5 months ago

I forgot to close out this issue as we addressed it a long time ago:

https://github.com/ladybug-tools/ladybug/commit/0f491dea92cdd697daccc6690e21fa7aab253eeb