search

ladybug-tools / ladybug

🐞 Core ladybug library for weather data analysis and visualization
https://www.ladybug.tools/ladybug/docs/
GNU Affero General Public License v3.0
191 stars 54 forks source link

EPW design conditions #604

Open cmsavage opened 1 year ago

cmsavage commented 1 year ago

It looks like some recent TMY EPW files on OneBuilding.org have a different format for the design conditions line ("2021 ASHRAE Handbook -- Fundamentals - Chapter 14 Climatic Design Information") that is different from what the EPW module is expecting form import (2009 ASHRAE?). The number of heating/cooling/extreme fields do not match, but I do not have a copy of the 2021 ASHRAE Handbook of Fundamentals to check what the new format might be. Relevant areas that would require updating (would need to newly keep track of the "design condition source" field instead of assuming 2009 ASHRAE?):

https://github.com/ladybug-tools/ladybug/blob/e70767b655e0c62da2efdf73cbb966d6ae3929d6/ladybug/designday.py#L69-L83 https://github.com/ladybug-tools/ladybug/blob/e70767b655e0c62da2efdf73cbb966d6ae3929d6/ladybug/epw.py#L445-L455 https://github.com/ladybug-tools/ladybug/blob/e70767b655e0c62da2efdf73cbb966d6ae3929d6/ladybug/epw.py#L809-L817

mostaphaRoudsari commented 1 year ago

Hi @cmsavage, Thank you for letting us know. I assigned @chriswmackey to this issue so he is aware of this issue.