search

ladybug-tools / radiance-folder-structure

⚡️📂Folder structure for Radiance studies
GNU Lesser General Public License v3.0
0 stars 2 forks source link

Clarify if dynamic nonopaque direct studies should use the blk modifier #14

Closed chriswmackey closed 4 years ago

chriswmackey commented 4 years ago

Right now, the dynamic opaque folder states that "we can use the same file with black materials for direct studies." I am guessing that this means the direct version of the dynamic opaque geometry is supposed to use the blk modifier by default, which seems ok.

However, the way that the dynamic nonopaque page is set up, it seems that the same logic should be applied here but, thinking about this more, this does not make sense. You would probably want the direct study with nonopaque geometry to use the same modifier as the given state by default (not a black material). So, if the direct file is not a black material, should there be a separate "black" key for dynamic nonopaque geometry like there is for dynamic apertures? Or will we never have a need to run isolation studies with dynamic shades and so we can still leave out the "black" key?

mostaphaRoudsari commented 4 years ago

Good question. Your assumption is correct that the non-opaque will stay non-opaque all the time. I think you are right that we can remove the 'black' key in this case. I cannot think of a case that it can be useful.

chriswmackey commented 4 years ago

This has been addressed via https://github.com/ladybug-tools/radiance-folder-structure/pull/16