search

ladybug-tools / radiance-folder-structure

⚡️📂Folder structure for Radiance studies
GNU Lesser General Public License v3.0
0 stars 2 forks source link

fix(json): Update states.json to use lists and not string integers #16

Closed chriswmackey closed 4 years ago

chriswmackey commented 4 years ago

This commit addresses this issue and this issue.

mostaphaRoudsari commented 4 years ago

Hey @chriswmackey, the parsing of dynamic windows has been implemented in Radiance Folder. We will need a parallel PR to fix the parsing:

https://github.com/ladybug-tools/honeybee-radiance-folder/blob/master/honeybee_radiance_folder/folderutil.py#L269-L292

chriswmackey commented 4 years ago

Ah. I guess I was only looking at this code here that raises a NotIplementedError. Ok. I'll work on a parallel PR for the folderutil module of honeybee-radinace-folder.

chriswmackey commented 4 years ago

The corresponding PR for honeybee-radiance-folder is all set up. We should be clear to merge following your final approval, @mostaphaRoudsari .

ladybugbot commented 4 years ago

:tada: This PR is included in version 3.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: