search

ladybug-tools / spider-2020

Your 2020 3D happy place for online browsing of building data files
http://ladybug.tools/spider-2020/
MIT License
4 stars 1 forks source link

HBJSON loaded but not visible #17

Open devang-chauhan opened 3 years ago

devang-chauhan commented 3 years ago

Hi @theo-armour,

I wish to use the viewer to visualize HBJSON files. I observed that when an HBJSON is created from Honeybee Rooms (i.e. Solids), the HBJSON loads well into the viewer and I can see it. However, when an HBJSON is created from Honeybee Faces, the HBJSON loads but nothing is visible on the Canvas. You can use this HBJSON that I generated today.

pollination viewer

Thanks, Devang

theo-armour commented 3 years ago

@devngc

Wow! A user! ;-)

Thank you for sending the HBJSON file. It loads nicely and the JSON tree viewer displays the data in the tree view and, as you show, nothing is visible.

I see that the faces and apertures are displayed as "orphaned_faces" and "orphaned_apertures" and I see that the JavaScript Console displays "No Honeybee 3D data"

The Viewer was designed for the Schema that existed in July or so. In that version, IIRC, all faces and apertures had to belong to a room. The only standalone faces were orphaned shades.

In your HBJSON file, there appears a thing called a "Face3D". I don't see anything like that in the scripts that I built. So I guess, it is not surprising that nothing is visible.

Sorry for this!

devang-chauhan commented 3 years ago

Hi @theo-armour,

Thank you for looking into it. All the geometries in the model were Ladybug Face3D objects. These Ladybug Face3D objects were turned into Honeybee Face, Aperture, and Sensorgrid objects. I would also share that this is not an edge case. We can expect other users to put together a Honeybee Model from faces using this method that Honeybee provides. I myself used this method to create HBJSON.

This is not urgent. I simply wanted to share this with you. Hope you are well.

theo-armour commented 3 years ago

@devngc @mostaphaRoudsari

This is not urgent.

Good! ;-)

I have no clear plans in mind for further development of the Spider Viewer efforts - apart from bug fixes. If I understand things correctly, @cdriesler has or is building a Honeybee Schema viewer somewhere. Once I know the link to it, I plan to add a deprecated notice to the Spider Pollination Viewer along with an instruction to accessing that viewer.

I think my role has been instrumental in a complex process. I proved you can display complex AEC data sets in interactive 3D in your browser on your computer/tablet/phone using entry-level free, open source software. Using viewers built by people who are also a Ladybug / Honeybee users (which is not me) and who are full-stack developers seems a much better and more elegant proposition for the future. And I will be delighted to help with those efforts as and when there are small and clearly defined challenges for me to tackle.

Theo

cdriesler commented 3 years ago

Hey! Yes you're right. But if my extended silence didn't make it obvious (sorry) I got whisked away to other projects since we last spoke.

I agree that we couldn't have pulled off the pollination version without your work. In the ways that matter, it basically is your work. We just added some buttons for swapping face colors around.

Development is scheduled to start on it again soon. If I come across them, you'll definitely hear from me with some well-formatted problems.

theo-armour commented 3 years ago

@cdriesler

All good to hear. BTW, a lot of the twisted faces issues in my code were updated in the gbXML viewer. Should also help with Honeybee Schema Viewers. See

https://github.com/ladybug-tools/spider-2020/blob/master/lib/gbxml/gbx-gbxml-parse-2020-10-09.js#L100-L165