search

ladybug-tools / spider-gbxml-fixer

Run basic text-based checks on gbXML files and uncover, report and fix any errors or issues found
https://www.ladybug.tools/spider-gbxml-fixer/
MIT License
2 stars 0 forks source link

Spider gbXML Fixer R0.4.7: Fix surfaces with an extra adjacent space #5

Closed mdengusiak closed 5 years ago

mdengusiak commented 5 years ago

Fix surfaces with an extra adjacent space - algorithm to be adjusted:

  1. check adj space if two are different this take priority and adj space remain

  2. change surface type to InteriorType...

  3. change CADObjectID to Spider default types: there are types we will replace to.. Basic Wall: SIM_INT_SLD SpiderFix [as in original element] Basic Wall: SIM_INT_GLZ SpiderFix [as in original element] Floor: SIM_INT_SLD_FLR SpiderFix [as in original element]

  4. for ElementID [111111] in CADObectID we keep original image

so in this example

we have: _surfaceType: ExteriorWall exposedToSun: true id: Panel-193 CADObjectId: Basic Wall : SIM_EXTGLZ WA17 [1091386]

we should fix to: _surfaceType: InteriorWall exposedToSun: false id: Panel-193 CADObjectId: Basic Wall : SIM_INTGLZ SpiderFix [1091386]

theo-armour commented 5 years ago

@mdengusiak

Please try "Fix surfaces with two adjacent spaces & incorrect surface type" in R0.4.8

mdengusiak commented 5 years ago

@theo-armour I am testing now I think there is issue with path..in Maevia.. we have now: https://www.ladybug.tools/spider-gbxml-fixer/dev

and this works fine https://www.ladybug.tools/spider-gbxml-fixer

michaldengusiak commented 5 years ago

I retested this and fine