search

ladybug-tools / spider-gbxml-fixer

Run basic text-based checks on gbXML files and uncover, report and fix any errors or issues found
https://www.ladybug.tools/spider-gbxml-fixer/
MIT License
2 stars 0 forks source link

Spider gbXML Fixer R0.4.7: Add Fix surfaces with incorrect CADObjectID #6

Closed mdengusiak closed 5 years ago

mdengusiak commented 5 years ago

Fix surfaces with incorrect CADObjectID - : this is connected fix with Get air surfaces with single adjacent space

  1. we have now: one adj space and ExeriorSurtfaceType
  2. check if CADObjectID include "AIR" replace to SpiderDeafult for CADObjectID

Basic Wall: SIM_EXT_SLD SpiderFix [as in original element] Basic Roof: SIM_EXT_SLD SpiderFix [as in original element] Floor: SIM_EXT_SLD_FLR SpiderFix [as in original element]

image

so in our example we have _surfaceType: Roof exposedToSun: false id: Panel-3051 CADObjectId: Floor: SIM_INT_AIR [1323050] Name: Panel-3051 AdjacentSpace spaceIdRef: Space040138VOID

we should change to _surfaceType: Roof exposedToSun: false id: Panel-3051 CADObjectId: Floor: Basic Roof: SIM_EXT_SLD SpiderFix [1323050] Name: Panel-3051 AdjacentSpace spaceIdRef: Space040138VOID

theo-armour commented 5 years ago

@mdengusiak

See:

Spider gbXML Fixer 'Atrax' R0.4.12

Check out:

Fix surfaces with two adjacent spaces & incorrect surface type

Fix Surfaces with CAD object ID missing

Lookup table needs work:

https://github.com/ladybug-tools/spider-gbxml-fixer/blob/master/r0-4-0/gbx-gbxml-core.js#L103-L122

michaldengusiak commented 5 years ago

tested and approved before image

after

image