ladybug-tools / spider-gbxml-tools

Scripts to help you view and manage gbXML files
https://www.ladybug.tools/spider-gbxml-tools/
MIT License
13 stars 3 forks source link

Spider gbXML Viewer 'Maevia' R15.23: Issue with surfaces Panel-276 and Panel-279 #30

Closed mdengusiak closed 5 years ago

mdengusiak commented 5 years ago

I have broken file that does not import into simulation tool, Panel-276 and Panel-279 are problematic.

I can see also problem in ver R12.34 as surface is not displaying but it does show in R15.23 without any error. We need to find what is problem with these surfaces and log this under issues in 'Maevia' we know what is problem inside gbXML.

image

image

test file: BHoMgbXMLrevitSAM_TAS.zip

theo-armour commented 5 years ago

@mdengusiak

I have had a quick look at the XML file and at the display in the viewers. It seems to me that the issue is that the mullions are just 6 mm. The surface is 4.5 high. The opening is 4.488 high.

Since R12 cuts holes in surfaces, so there is nothing left to see in R12 and becomes almost invisible. R15 draws the outline of an opening but does not yet cut holes - so you see the full surface.

I think the model is OK and provides a good test case for how should we build a viewer that helps you identify and handle surfaces with near full-size openings.

mdengusiak commented 5 years ago

@theo-armour OK I manage to isolate issue and here is just two zone model with problem BHoMgbXMLrevit2zones_TAS.zip What it is actually Curtain Wall System Panel from two different walls have same geometry and this is wrong in XML. Would be good to get some check and highlight under issue.

here are images: https://github.com/BHoM/Revit_Toolkit/issues/248

mdengusiak commented 5 years ago

to be fix by Fixed