Aragog R13 > Issues Panel >Duplicate coordinates workflow ~ update 2018-05-24

theo-armour commented 6 years ago

@mdengusiak @EK-CEL

R13 Issues panel > R13 Duplicate Coordinates >

This panel has a 'delete duplicate surfaces button'. Currently when the pop-up appears all the duplicates are displayed and you can uncheck the surfaces you want to keep.

The goal must be to have the best choice of surfaces already selected when the pop-up appears.

For example, we could have a simple rule such as: whatever is the second selected surface in the list of pairs could be pre-selected to delete and the first selected surface is unchecked.

Or we could have rules such as: if one surface is internal wall and one surface is air, then select the air to be deleted.

BTW, when there is a need for multiple seection I think I will switch from a selecting from a list box over to selecking by using checkboxes and text that scroll in a box. The reason is amusing and unusual: I only have one hand so using the control key and mouse to select multiple items in a list box is difficult to accomplish and really slows down my testing. ;-)

Note: this issue is just about the duplicate surfaces/coordinates panel. There will be another issue for duplicate adjacent spaces and so on.

Here. I just need to hear good suggestions for a speedy workflow for deleting duplicate surfaces.

theo-armour commented 6 years ago

@mdengusiak @EK-CEL

http://www.ladybug.tools/spider/gbxml-viewer/dev/

Some progress

The left menu Issues panel has a 'Delete duplicate surfaces' button. This brings up a dialog in the popup window where you can select what is to be deleted. The default is that every second time found is checked as needing to be deleted and so on.

This is still a work-in-progress

There are issues with the logic of selecting and deselecting items to be deleted.
There are issues with both 'save changes' and 'save file' methods of saving data.

If you can think of alternative logic or rules for selecting which duplicates should be or could be selected for deletion, please do comment.

Anyway, the proof-of-concept goal may be in sight: let the app fix things so that you can get on with the analysis with fewer headaches.

EK-CEL commented 6 years ago

Having a single list of paired elements it is easy to loose a focus - is this element first of second after the previous one? As far as we always have pairs of duplicated elements it would be logical to see them in two columns: one beside another. Then we can check elements in the left column (for firsts elements) or in the right one (for secondary elements).

mdengusiak commented 6 years ago

@theo-armour

To clarify this is just a List list of panels where we compare geometry and properties,

Please update description as this Issue to it is clear to everyone Two surfaces with the same coordinates and same properties (Adjacent Spaces and CADObjectID) So there are exactly same surfaces and should not matter which one we delete. I always prefer to delete second one from list. To have first surface create to remain, I suggest in this script just delete always second item from list and this is exactly what you have already implemented.

I love how it works and this is great!

Save Changes to filedoes not work for me...

theo-armour commented 6 years ago

@EK-CEL

Having a single list of paired elements it is easy to loose a focus

is this element first of second after the previous one?

I very much agree. I am having isues debugging the code just because it is easy to forget where you are.

This needs to be fixed - somwhow

Things I am finding:

Not all duplicates are duplicates. Some are triplicates and maybe more! I am not yet certain about this but, for example, in the drawing you uploaded it takes me two passes to delete all the duplicates successfully. We need to prove that there are indeed triplicates. And, if so, then they must be highlighted as a group and made delete-able - both in a single pass

The current select item/view attributes panel - see above - is based on a single function used in many places in the code. And it seems to be OK on both big and small screens. The issue for me is that I let the code get too complicated and enhancing/debugging it takes time. Having said that, I think that adding the ability to highlight and.or select multiple items is essential. So this will happen.

An the ultimate goal: the correct items are deleted and dealt with properly on an automatic basis. You can get data from CAD to analysis with a single click. Fingers crossed we get there soon and the user interface becomes less important. ;-)

@mdengusiak

Save Changes to file does not work for me...

It's broken for me too. Will fix.

The 'Save changes' button does seems to be working OK for me. And a saved file did report no duplicates for me in the one test I have done.

theo-armour commented 6 years ago

@EK-CEL @mdengusiak

Arragog R13.26

R13.26

Duplicate Coordinates Panel
- Popup Window: Add displays multiple duplications as a group of color coded items
- Add 'check duplicate adjacent spaces' button << not looking useful
- Fix 'save file' button not working

My 'theory' of yesterday looks like being correct: A model may have surfaces that are duplicated more than once. In order to show this, iItems with identical coordinates all share the same color in the popup window.

It looks like the options in the left menu - see below - could also be colored but that will happen another day

Question

As items get checked and unchecked in the popup window: should the visibility of these items in the main screen also automatically turn off and on? Or should there be separate buttons for this?

EK-CEL commented 6 years ago

Placing a note about the duplicates I kept in mind that it could be triplicates, etc. But I tried do not think about that as it compromised the idea with columns. :) I thought to group elements in the Navisworks manner when it displays clashes. But it doesn't look well for tablet input. @theo-armour, your idea with group colors is great. I like it.

Trying answering the question. I think the interface should be consistent: if a line in a list is selected (not checked) then an element gets highlighted in the model. As we move select another line we get the previous element hidden and the new one highlighted. It should be "auto zoom" button there, or/and we should be able to zoom to the element manually (does double-click on the line work?).

theo-armour commented 6 years ago

R13.27

Saving edits and saving changes both seem to be working, but have been only lightly tested

ladybug-tools / spider