ladybug-tools / spider

:spider_web: 3D interactive analysis in your browser mostly written around the Three.js JavaScript library
http://www.ladybug.tools/spider
44 stars 15 forks source link

Openings are surfaces #123

Closed EK-CEL closed 5 years ago

EK-CEL commented 6 years ago

Here is a scenario: I want to see surfaces for the Storey 1 only. I activate it in [Reports]. Now I see shaded surfaces for that storey and the rest of the storeys are shown with edges. Except openings: they still are shaded: image It is not expected. I believe we can consider an opening as kind of surface, it is flat. So I expect similar behavior for it. Also a surface and an opening are in parent-child relationship. If a wall is shown with edges, then its sub-components like openings (doors and windows) should follow the parent's setting and be displayed with edges.

EK-CEL commented 6 years ago

There is another issue related to that. I hide interior walls and expect that openings belonging the walls disappear with the walls. Unfortunately they don't do that for the moment. image I found it very distracting on model review. Please make openings disappearing with parent wall, it will help to focus on envelope surfaces only.

theo-armour commented 6 years ago

@EK-CEL

Thank you for the heads-up. Openings are a new element in the Viewer. A nice workflow is still a work-in-progress. I also can end up clicking all over the place to get the view that is needed. ;-) So do keep reporting.

I think I have fixed the issues in your first comment.

I'm not certain about how to reproduce the issue in your second comment. In any case, openings have their own toggle buttons in all three menus so their visibility can be set independently of other surfaces.

image

EK-CEL commented 6 years ago

@theo-armour Here is the video demonstrating how we can hide interior walls, but not openings in those walls.

EK-CEL commented 6 years ago

Is the issue with opening for hidden storeys fixed for the version 13.27? I am asking because I still can see them. Here is the video.

theo-armour commented 6 years ago

Thanks for the video. I get the picture

i will look into fixing this. Openings are a new feature. It may take me a while to get to grips with it all

PS. It took me a while to get my Flash player going again so I could view the video on Screencast.

On Fri, May 25, 2018 at 11:09 AM, EK-CEL notifications@github.com wrote:

Is the issue with opening for hidden storeys fixed for the version 13.27? I am asking because I still can see them. Here is the video https://www.screencast.com/t/X3nrjo5kX.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ladybug-tools/spider/issues/123#issuecomment-392137770, or mute the thread https://github.com/notifications/unsubscribe-auth/AAhbKiinPfwTyQxk6uzr6FNOtd5lUZyxks5t2EjEgaJpZM4UMLXE .

theo-armour commented 6 years ago

@EK-CEL

I looked into the openings visible on hidden storeys issue and it will be fixed. But this will most likely come in with R14 because that will have 'smarter' clickable openings and more.

And, not to worry about delays, R14 is already cooking.

theo-armour commented 5 years ago

Generally, handling of openings as objects is progressing well, though the effort not complete