search

ladybug-tools / spider

:spider_web: 3D interactive analysis in your browser mostly written around the Three.js JavaScript library
http://www.ladybug.tools/spider
44 stars 15 forks source link

Update parser to read in different coordinate ordering for walls. #131

Closed bwelle closed 6 years ago

bwelle commented 6 years ago

Working wall coordinates are: grey_0.6 polygon ExteriorWall.surface-21 0 0 30 -15.240000 15.240000 0.000000 -15.240000 15.240000 3.048000 15.240000 15.240000 3.048000 15.240000 15.240000 0.000000 10.159898 15.240000 0.381000 -10.159898 15.240000 0.381000 -10.159898 15.240000 2.667000 10.159898 15.240000 2.667000 10.159898 15.240000 0.381000 15.240000 15.240000 0.000000

Not working coordinates are: grey_0.6 polygon ExteriorWall.surface-21 0 0 30 15.240000 15.240000 0.000000 10.159898 15.240000 0.381000 -10.159898 15.240000 0.381000 -10.159898 15.240000 2.667000 10.159898 15.240000 2.667000 10.159898 15.240000 0.381000 15.240000 15.240000 0.000000 -15.240000 15.240000 0.000000 -15.240000 15.240000 3.048000 15.240000 15.240000 3.048000

File with not working coordinates in test-case-1 directory. Named as such. Both these orders are valid in Radiance.

theo-armour commented 6 years ago

@bwelle

This issue needs several sample files from the same source so we can assure that the fix works for all files from the given source.

One day, we should have code that will build the correct surface no matter the order of the coordinates.

But for now - in the still early stages of things - it is better to build code based on a custom code for each source of the .rad files.

bwelle commented 6 years ago

Yes sir. We are close. In fact realized that last .rad file I sent is invalid Radiance geometry. Sending update.

Benjamin Welle, PhD, PE, LEED AP BD+C Director of Energy Lab Nicollett Mall, IDS Center, 80 S 8th St #300, Minneapolis, MN 55402 t 415.856.3000 m 858.344.6858 benjamin.welle@perkinswill.commailto:benjamin.welle@perkinswill.com

Perkins+Will Ideas + buildings that honor the broader goals of society perkinswill.comhttp://www.perkinswill.com/|Bloghttp://blog.perkinswill.com/ | Facebookhttp://www.facebook.com/ideasandbuildings | Twitterhttp://www.perkinswill.com/pages/twitter.html

From: Theo Armour [mailto:notifications@github.com] Sent: Monday, June 18, 2018 8:21 PM To: ladybug-tools/spider spider@noreply.github.com Cc: Welle, Benjamin Benjamin.Welle@perkinswill.com; Mention mention@noreply.github.com Subject: Re: [ladybug-tools/spider] Update parser to read in different coordinate ordering for walls. (#131)

@bwellehttps://github.com/bwelle

This issue needs several sample files from the same source so we can assure that the fix works for all files from the given source.

One day, we should have code that will build the correct surface no matter the order of the coordinates.

But for now - in the still early stages of things - it is better to build code based on a custom code for each source of the .rad files.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/ladybug-tools/spider/issues/131#issuecomment-398244190, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AbaYGiCvP0AFi3AUJrxkA0v3w8LPzUpaks5t-FHhgaJpZM4UiE2u.